Core 1264 port default layout part 1 #2783
Conversation
RoyEJohnson
force-pushed
the
core-1264-port-default-layout-part-1
branch
2 times, most recently
from
76c81bc to
bf04c06
Compare
There was a problem hiding this comment.
Removed the Welcome code, which was for use with my_openstax, which has been mothballed.
| return ( | ||
| <div className="page-header"> | ||
| <JITLoad importFn={() => import('./sticky-note/sticky-note.js')} stickyData={stickyData} /> | ||
| <StickyNote stickyData={stickyData} /> |
There was a problem hiding this comment.
Having this load dynamically was not worth the hassle.
| import PutAway from '~/components/put-away/put-away'; | ||
| import './shared.scss'; | ||
|
|
||
| // Shim for incognito windows that disable localStorage |
There was a problem hiding this comment.
Moved this to main.js
test/src/components/shell.test.tsx
Outdated
| await screen.findByText('What is your question about?'); | ||
| expect(screen.queryAllByRole('navigation')).toHaveLength(0); | ||
| }); | ||
| it('handles piTracker ', async () => { |
There was a problem hiding this comment.
This test fails regularly, and it is tested in user-link-handler.test anyway, so no need to do it here.
| expect(button.parentElement?.classList.contains('active')).toBe(true); | ||
| await user.keyboard('{Escape}'); | ||
| expect(button.parentElement?.classList.contains('active')).toBe(false); | ||
| // If clicked when not active, it does nothing |
There was a problem hiding this comment.
This code is tested in the layouts/default test now.
RoyEJohnson
force-pushed
the
core-1264-port-default-layout-part-1
branch
2 times, most recently
from
7e1e538 to
5bda6f8
Compare
RoyEJohnson
force-pushed
the
core-1264-port-default-layout-part-1
branch
3 times, most recently
from
5c36bd1 to
9850b0d
Compare
RoyEJohnson
force-pushed
the
core-1264-port-default-layout-part-1
branch
from
27387cc to
05ae3c4
Compare
RoyEJohnson
force-pushed
the
core-1264-port-default-layout-part-1
branch
from
05ae3c4 to
f820044
Compare
| import type {ArticleData} from '~/pages/blog/article/article'; | ||
| import userEvent from '@testing-library/user-event'; | ||
|
|
||
| // @ts-expect-error does not exist on |
There was a problem hiding this comment.
I had several of these routerFuture settings leftover.
RoyEJohnson
force-pushed
the
core-1264-port-default-layout-part-1
branch
from
f820044 to
7e06c2b
Compare
src/app/main.js
Outdated
| clear() {}, | ||
| key() {return null;}, | ||
| length: 0 | ||
| }; |
There was a problem hiding this comment.
Probably very edge case, but this doesn't seem to work if I disable localstorage in chrome. Maybe we should add a proxy? At the least, we can wrap it in a try to prevent the set property error (I only tested chrome, not sure if firefox and safari behave differently.)
There was a problem hiding this comment.
I examined the code to ensure that it is set up to handle missing/restricted localStorage, and removed the shim.
2 participants
CORE-1264
The first installment of porting layouts/default to TypeScript, covering
footer
header.tsx
header/menus/menus.tsx
header/menus/give-button
header/menus/logo
header/menus/menu-expander
header/menus/upper-menu
header/sticky-note
lower-sticky-note
shared (coverage not quite complete here)